Fix missing null return type for Generator::current() & Generator::key() #1711

tscni · 2025-01-13T20:22:06Z

For some reason #1280 changed the return type of Generator::current() from TYield|null to TYield, which is not correct.
Similarly, Generator::key() can return null as well.

For reference: https://3v4l.org/aSMe8

$generator = (function () {
    yield 0;
})();

var_dump($generator->current()); // 0
var_dump($generator->key()); // 0

$generator->next();

var_dump($generator->current()); // null
var_dump($generator->key()); // null

Fix missing null in generator return types

b1b8171

isfedorov merged commit 991fd13 into JetBrains:master Sep 17, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix missing null return type for Generator::current() & Generator::key() #1711

Fix missing null return type for Generator::current() & Generator::key() #1711

Uh oh!

tscni commented Jan 13, 2025

Uh oh!

Uh oh!

Fix missing null return type for Generator::current() & Generator::key() #1711

Fix missing null return type for Generator::current() & Generator::key() #1711

Uh oh!

Conversation

tscni commented Jan 13, 2025

Uh oh!

Uh oh!